From: Georges Basile Stavracas Neto <georges.stavracas@gmail.com>
Date: Tue, 25 May 2021 15:03:46 +0000 (-0300)
Subject: workspaceThumbnail: Destroy thumbnails on destruction
X-Git-Tag: archive/raspbian/50.5-1+rpi1~1^2~574^2^2~275
X-Git-Url: https://dgit.raspbian.org/%22http://www.example.com/cgi/%22/%22http:/www.example.com/cgi/%22?a=commitdiff_plain;h=e9119c625dc22d892bdf04be6e9d56d598feabbe;p=gnome-shell.git

workspaceThumbnail: Destroy thumbnails on destruction

Often, when using multiple monitors, the thumbnails box may be
destroyed before the 'hidden' signal of the Overview is emitted,
which leaves a bunch of lingering signal connections to the
workspace manager.

Call this._destroyThumbnails() in the _onDestroy handler, which
disconnects from workspace manager. This fixes the some of the log
spam that GNOME Shell produces with backtraces of destroyed actors.

Part-of: <https://gitlab.gnome.org/GNOME/gnome-shell/-/merge_requests/1860>
---

diff --git a/js/ui/workspaceThumbnail.js b/js/ui/workspaceThumbnail.js
index 3a7d916ca..412527c93 100644
--- a/js/ui/workspaceThumbnail.js
+++ b/js/ui/workspaceThumbnail.js
@@ -720,6 +720,7 @@ var ThumbnailsBox = GObject.registerClass({
     }
 
     _onDestroy() {
+        this._destroyThumbnails();
         this._unqueueUpdateStates();
 
         if (this._scrollValueId)